fix: audio interruption on android #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsahil03x
reviewed
Nov 25, 2025
Co-authored-by: Sahil Kumar <xdsahil@gmail.com>
Copilot finished reviewing on behalf of
xsahil03x
November 25, 2025 10:18
There was a problem hiding this comment.
Pull request overview
This pull request fixes audio interruption handling on Android by consolidating audio focus management through AudioSwitch and adding permission checks to prevent crashes related to telephony state monitoring.
- Deprecated unused audio attribute parameters (
androidAudioAttributesUsageTypeandandroidAudioAttributesContentType) that are no longer needed with the new AudioSwitch-based approach - Implemented a forwarding listener pattern to allow dynamic audio focus listener updates without recreating AudioSwitch
- Added comprehensive permission checking and error handling for telephony state monitoring to prevent SecurityExceptions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/native/factory_impl.dart | Deprecated audio attribute parameters and removed their usage in method call arguments |
| lib/src/helper.dart | Added regainAndroidAudioFocus() helper method for manually requesting audio focus |
| android/src/main/java/io/getstream/webrtc/flutter/audio/AudioSwitchManager.java | Introduced ForwardingAudioFocusChangeListener pattern and setAudioFocusChangeListener() method for dynamic listener management |
| android/src/main/java/io/getstream/webrtc/flutter/audio/AudioFocusManager.java | Refactored to use AudioSwitch for focus changes, added permission checking, improved thread safety with interruption state tracking, and added try-catch for telephony registration |
| android/src/main/java/io/getstream/webrtc/flutter/MethodCallHandlerImpl.java | Removed deprecated audio attribute parameter handling, added regainAndroidAudioFocus case, and cleanup in dispose method |
| CHANGELOG.md | Documented the audio focus improvements and new API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
android/src/main/java/io/getstream/webrtc/flutter/audio/AudioFocusManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/AudioSwitchManager.java
Show resolved
Hide resolved
xsahil03x
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AudioSwitch for focus change listener to have a single source of focus truth.
Check phone state permissions to avoid crashes